fix: run tidy-ci instead of tidied#19
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the reusable CI workflow’s “Go mod tidy” job so tidied (and module-specific tidy logic) can be applied across multiple Go modules within a repository, rather than only the root module.
Changes:
- Runs
tidied -verbosefor the root module. - Iterates over tracked
go.modfiles and runsmake tidy-ciin each module directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
As noted in oapi-codegen/oapi-codegen#2372, otherwise this leads to cases where we're not correctly `go mod tidy`ing across the project. As all our projects have a `tidy-ci`, we can use that task.
jamietanna
changed the title
tidied across all go.modstidy-ci instead of tidied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in oapi-codegen/oapi-codegen#2372,
otherwise this leads to cases where we're not correctly
go mod tidyingacross the project.
As all our projects have a
tidy-ci, we can use that task.